ClassicPress Bots

WordPress commits: wp-trunk branch

git: da4f8d0
svn: r44794
1 of 1494
Author
Peter Wilson <[email protected]> 2019-03-05 01:51:31 +0000
Comments: Allow for `comment-reply.js` to be loaded in the HTML header.
Allows for themes or plugins setting the comment-reply JavaScript as a dependency of an HTML header script. This in turn causes `comment-reply.js` to be loaded early, requiring execution to be delayed.

Props pento, peterwilsoncc, jorbin for feedback.
Fixes #46280.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e8fa2d6
svn: r44793
2 of 1494
Author
Andrea Fercia <[email protected]> 2019-03-04 22:45:24 +0000
Accessibility: Hide the Toolbar sub-menu CSS generated icons from assistive technologies.
CSS generated content is rendered for speech output. When it's not meant to be announced by assistive technologies, for example with font icons, special care should be used to hide it. At the moment, the only reliable way to do this is making use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4a09766
svn: r44792
3 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-03-04 22:19:05 +0000
Privacy: Remove two test methods that fail on certain configurations.
The `test_detects_cannot_create_index()` and `tests_detects_cannot_write_html()` test methods are prone to failure under certain configurations, as discovered by the hosts reporting back the test suite results. This removes those two methods until a better approach to testing those scenarios can be created.

Partial revert of [44786].
See #44233.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 19abdee
svn: r44791
4 of 1494
Author
Andrea Fercia <[email protected]> 2019-03-04 22:01:10 +0000
Coding standards: Fix incorrect CSS `rgba()` values.
Also, fixes some indentation where spaces were used instead of tabs.

Props nielslange, mukesh27.
Fixes #45937.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d80e627
svn: r44790
5 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-03-04 21:32:02 +0000
Build/Test Tools: Fix validation error in multisite PHPUnit configuration file.
A PHPUnit configuration file with more than one `<php>` tag causes a validation error in PHPUnit versions 7.x. There are currently 2 in the `tests/phpunit/multisite.xml` file, which appears to be accidentally introduced in [29954].

Fixes #46414.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 521c4a8
svn: r44788
6 of 1494
Author
Felix Arntz <[email protected]> 2019-03-04 21:13:45 +0000
General: Introduce `wp_is_php_version_acceptable` filter to make the check for triggering PHP version warnings stricter.
The filter is only run if the wordpress.org API considers the PHP version acceptable. This ensures that other plugins or hosting providers can only make this check stricter, but not loosen it.

Props j-falk, mikeschroder.
Fixes #46065.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0e59ee5
svn: r44787
7 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-03-04 20:46:25 +0000
Privacy: Remove privacy feature related admin pointers.
In 4.9.6, several new privacy related features were introduced. Admin pointers were included to make administrators aware of these features. They have served their purpose and can now go silently into the night.

Props garrett-eclipse, desrosj, xkon.
Fixes #45999.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 636af90
svn: r44786
8 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-03-04 19:35:30 +0000
Privacy: Add missing unit tests for exporting personal data.
Props allendav, birgire, iandunn, desrosj, garrett-eclipse.
Fixes 44233.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e421f26
svn: r44785
9 of 1494
Author
Aaron Jorbin <[email protected]> 2019-03-01 20:57:26 +0000
Replace usages of basename() with wp_basename() in order to support multibyte filenames
This is focused on the pieces of code that touch media files and the tests that support them. `basename` isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4c45ff7
svn: r44784
10 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 22:57:47 +0000
Users: Revert [44780] pending test failure investigation.
See #45845.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 91e5365
svn: r44782
11 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-02-28 21:43:04 +0000
Editor: Allow the default font size options to be removed.
Similar to `editor-color-palette`, a theme or plugin should be able to set the theme support for `editor-font-sizes` to an empty array, indicating that no additional font sizes should be available in the block’s ‘Text Settings’. The current conditional was using `empty()`, which was incorrectly causing the default font sizes to be used instead.

Props jorgefilipecosta, chrisvanpatten, SergeyBiryukov.
Fixes #46290.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: faa0bcd
svn: r44781
12 of 1494
Author
Adam Silverstein <[email protected]> 2019-02-28 20:10:53 +0000
Revisions: improve display responsiveness, especially on smaller screen sizes.
* Fix an overlap issue with the "Restore this Revision" button that made it difficult to use on phone sized devices.

Props ryan, PranaliPatel, karinedo.
Fixes #33830.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a16cbba
svn: r44780
13 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 14:38:27 +0000
Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`.
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 169a73a
svn: r44779
14 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 12:07:20 +0000
Privacy: Escape Privacy Policy guide URL in in Privacy Policy edit page notice.
Props itowhid06, garrett-eclipse.
Fixes #44761.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4620357
svn: r44778
15 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 12:00:45 +0000
Privacy: Improve translator comments for Privacy Policy page links in Privacy Settings; escape URLs.
Props birgire, garrett-eclipse.
Fixes #46369.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9074c8d
svn: r44777
16 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 11:48:46 +0000
Privacy: Return a more accurate error message when the user cannot perform the requested action.
Props mmuhsin, jplojohn, garrett-eclipse, desrosj.
Fixes #44833.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 010cdb3
svn: r44776
17 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 11:43:24 +0000
Login and Registration: Update URLs for browser cookie documentation.
Props joostdevalk.
Fixes #46254.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 835279c
svn: r44775
18 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 11:36:54 +0000
Privacy: Change "Email Data" link text on "Export Personal Data" screen to "Send Export Link" for clarity.
Previously: [43172], accidentally reverted in [43212].

Props birgire, ianbelanger.
Fixes #44822. See #43964.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ebe84c7
svn: r44774
19 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 02:46:39 +0000
Twenty Nineteen: Remove stray `÷` character in `print.css`.
Props mukesh27, laurelfulford.
Fixes #46083.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 37c5efc
svn: r44773
20 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 02:43:09 +0000
Twenty Nineteen: Update `style-rtl.css` after [44657].
See #45731.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9cc6caa
svn: r44772
21 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 02:06:30 +0000
Docs: Add missing `WP_Customize_Control` reference to `WP_Customize_Nav_Menu_Control` and `WP_Customize_Nav_Menu_Item_Control` DocBlocks.
Props aniketpatel.
Fixes #46077.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3574d43
svn: r44771
22 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-28 01:54:14 +0000
Twenty Nineteen: Avoid nested comment author links in `TwentyNineteen_Walker_Comment::html5_comment()`.
Props iamdmitrymayorov, mukesh27.
Fixes #46291.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3d246f9
svn: r44769
23 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-02-26 15:38:36 +0000
Help/About: Fix mismatched opening/closing tags.
The 5.1 About page contains some invalid HTML markup.

Props bulletdigital.
Fixes #46319.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 545ff1a
svn: r44768
24 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-02-25 15:20:23 +0000
Build: Minify images
After `grunt-contrib-imagemin` was upgraded in WordPress 5.0, the `grunt precommit:image` task results in further minifications to `loading.gif`.

Fixes #46295.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4e02973
svn: r44767
25 of 1494
Author
Andrea Fercia <[email protected]> 2019-02-23 18:31:05 +0000
Accessibility: Improve the image and gallery widgets preview accessibility.
In an authoring context, the image `alt` attribute purpose is different from the one for the front end. For example, screen reader users need to know what the selected image is, even when the original `alt` value is empty.

This change introduces a new pattern for the `alt` text in an authoring context:
- uses the `alt` text if not empty
- when there's no `alt` text, informs users the image has no alternative text and provides a reference to the image filename

Also, makes the gallery media widget preview an unordered list to make screen readers announce the number of images automatically.

Fixes #43137.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3086279
svn: r44762
26 of 1494
Author
Aaron Jorbin <[email protected]> 2019-02-21 21:18:49 +0000
Script Loader: Load fakejshint as jshint due to "good and evil".
Originally fixed in [42547]. Broken in [44163]. We've been here before. I recognize that tree.

Fixes #46299


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9448313
svn: r44760
27 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-21 04:34:39 +0000
Upgrades: Update `$_old_files` for WordPress 5.1.
`wp-includes/random_compat/random_bytes_openssl.php` was removed in [43130], this commit updates `$_old_files` to match.

Fixes #46284.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2181628
svn: r44759
28 of 1494
Author
Andrea Fercia <[email protected]> 2019-02-20 23:36:26 +0000
Accessibility: Comments: Improve links and buttons semantics and interaction.
With the exception of the "Edit" link, the "row actions" controls in the Comments table behave differently depending if JavaScript support is on or off.
When JavaScript support is off, they behave like links. When JavaScript support is on, they behave like buttons and they need to be buttons or have an ARIA `role="button"` added via JavaScript.

Lastly, the buttons in the Reply/Quick Edit form and the "Add Comment" in the edit post page meta box need to be buttons.

Fixes #43412.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 36381ad
svn: r44758
29 of 1494
Author
Andrea Fercia <[email protected]> 2019-02-20 22:55:19 +0000
Accessibility: General Settings: Update custom date/time format previews while typing.
The custom date/time format previews in General Settings were updated only when blurring the related input fields. With this change, they're now updated when users finish typing a custom format, properly debouncing the `input` event callback.

Props dilipbheda, Girishpanchal.
Fixes #43364.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6a32cc1
svn: r44757
30 of 1494
Author
Andrea Fercia <[email protected]> 2019-02-20 22:08:23 +0000
Accessibility: Improve buttons placement in the Comments Quick edit/Reply form.
Proximity of related information is an inclusive design principle that benefits everyone and it's particularly important for users with reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close to each other.
Also, this change makes the buttons visual order and the DOM order match.

Fixes #45972.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: cf8c68f
svn: r44756
31 of 1494
Author
Andrea Fercia <[email protected]> 2019-02-20 19:02:12 +0000
Accessibility: Remove unnecessary fieldset and legend elements from the User Profile page.
Also fixes a CSS margin issue in the mobile view.

Props punit5658.
Fixes #46093.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: bd3ee17
svn: r44755
32 of 1494
Author
Boone Gorges <[email protected]> 2019-02-19 20:23:11 +0000
Taxonomy: Remove `@ignore` annotation on `_get_term_hierarchy()`.
Originally introduced in [32453], the `@ignore` annotation caused the
function to be improperly ignored by the Code Reference parser.

The `@access private` annotation is the correct way to mark a
function for internal use only.

Props coffee2code.
Fixes #45997.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9179db7
svn: r44749
33 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-19 01:56:43 +0000
Admin: Update the About page design to match mockups.
This commit also moves the images to s.w.org, removes the old "Gutenberg has been deactivated" warning, as well as removing some old JS from About pages of years gone past.

Props melchoyce, ryelle, paaljoachim, karmatosed, pento.
Fixes #46161.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fc2a8f0
svn: r44748
34 of 1494
Author
Peter Wilson <[email protected]> 2019-02-18 04:26:09 +0000
Comments: Fix backward compatibility regressions in comment reply JavaScript.
Adds a `MutationObserver` to `comment-reply.js` to allow for lazy-loaded comments to continue working without the need to re-initialize the comment form.

Props Pento.
Fixes #46260.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a774b5a
svn: r44747
35 of 1494
Author
pento <[email protected]> 2019-02-17 22:23:02 +0000
Accessibility: Fix a regression in the old media modal pagination links.
[43019] improved the table pagination link styling, but introduced a regression in the old media dialog.

Props afercia, joneiseman.
Fixes #41858.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6edf515
svn: r44746
36 of 1494
Author
Peter Wilson <[email protected]> 2019-02-14 00:53:41 +0000
Trunk is now 5.2-alpha.
Update package.json missed in [44742].



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 41e264f
svn: r44744
37 of 1494
Author
Peter Wilson <[email protected]> 2019-02-14 00:41:15 +0000
Build: Fix formatting issues introduced in [44740].
See #46218.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d6e0473
svn: r44742
38 of 1494
Author
Peter Wilson <[email protected]> 2019-02-14 00:12:13 +0000
Trunk is now 5.2-alpha.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3ec3100
svn: r44740
39 of 1494
Author
Peter Wilson <[email protected]> 2019-02-14 00:06:39 +0000
Build: Remove source map from `jquery.form.min.js`.
Minimize jquery.form.js as part of build process to remove the source map reference. 

Modify source map tests to include all JavaScript files rather than testing Backbone and jQuery only.

Props pento.
Fixes #46218.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e7e42ef
svn: r44739
40 of 1494
Author
laurelfulford <[email protected]> 2019-02-13 18:39:59 +0000
Twenty Nineteen: Update the quote block styles.
Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.

Props @kjellr.
Fixes #46239.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 41d644c
svn: r44738
41 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-02-12 16:51:12 +0000
Upgrade/Install: Update character count for the `$table_prefix` config line after [43650] and [42343].
Fixes #46220.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 83275aa
svn: r44737
42 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-08 02:22:08 +0000
Post WordPress 5.1 RC1 version bump.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 508846a
svn: r44736
43 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-08 02:13:42 +0000
WordPress 5.1 RC1.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4b1885c
svn: r44735
44 of 1494
Author
Peter Wilson <[email protected]> 2019-02-08 01:52:17 +0000
Admin: Improve logic of PHP version check on about page.
Props noisysocks, peterwilsoncc.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 985958f
svn: r44734
45 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-08 01:27:39 +0000
Admin: Fix code formatting issues in the About page.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ab1bf7b
svn: r44733
46 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-08 01:24:57 +0000
Admin: Initial version of the WordPress 5.1 About page.
This includes the final strings, the design will continue to iterate.

Props mcsf, noisysocks, melchoyce, azaozz, afragen, JeffPaul, peterwilsoncc, andreamiddleton.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ef74cf5
svn: r44732
47 of 1494
Author
Peter Wilson <[email protected]> 2019-02-08 00:15:54 +0000
Install/upgrade: Remove Gutenberg plugin deactivation from upgrade process.
The Gutenberg plugin will not be deactivated on sites upgrading to WordPress 5.1. This deprecates the `upgrade_500_was_gutenberg_active` option and the `upgrade_500()` function as they are no longer required.

Props peterwilsoncc.
Fixes #46029.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d2f4156
svn: r44731
48 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-07 23:34:22 +0000
Formatting: Loosen the type checking in `_sanitize_text_fields()`.
[44618] added strict type checking to `_sanitize_text_fields()`, which has caused some compat issues with plugins.

We can loosen the type checking to only reject objects and arrays, and cast other types to string.

Props Nick_theGeek, pento.
Fixes #41450.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2a49b5c
svn: r44730
49 of 1494
Author
laurelfulford <[email protected]> 2019-02-07 23:22:04 +0000
Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.1.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #46070.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 98bee9b
svn: r44729
50 of 1494
Author
Riad Benguella <[email protected]> 2019-02-07 09:01:10 +0000
Block Editor: Update WordPress Packages to solve PHP 5.2.2 parser incompatibility.
Updated:

 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Props pento.
Fixes #46200.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1074530
svn: r44728
51 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-07 06:26:48 +0000
Build: Update `package.json` dependencies to match Gutenberg.
Props wpscholar, azaozz, gziolo.
Fixes #46039.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6b2c62e
svn: r44727
52 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-07 06:03:32 +0000
Multisite: After creating a new blog, ensure the blog cache is correctly cleaned up.
Props david.binda, spacedmonkey.
Fixes #46125.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 17a022e
svn: r44726
53 of 1494
Author
Gary Pendergast <[email protected]> 2019-02-07 04:11:23 +0000
Admin: Re-add some validation from [44048] that was accidentally removed in [44165].
Props david.binda.
See #45037.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 666d713
svn: r44725
54 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-02-06 18:36:49 +0000
Themes: Revert returning the value of `locate_template()` in functions that call it.
Because the names of the `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions indicate that a value is returned, some plugins and themes already have `echo get_template_part()` in their codebase. Adding a return value to these functions using the approach in [44678] will cause the two unintended side effects of unexpected content being sent to the browser, and accidental path disclosure.

Reverts [44678].

Props davidbinda.
See #40969.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5f38ce3
svn: r44724
55 of 1494
Author
Andrew Ozz <[email protected]> 2019-02-05 17:46:25 +0000
TinyMCE: fix color of highlighted drop-down menu items in Classic Block.
Fixes #46164.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3e19129
svn: r44723
56 of 1494
Author
Sergey Biryukov <[email protected]> 2019-02-03 22:40:56 +0000
Build/Test Tools: Display a message about currently supported PHPUnit branch to avoid fatal errors on later versions.
See #46149.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 56f3057
svn: r44722
57 of 1494
Author
peterwilsoncc <[email protected]> 2019-02-01 02:13:02 +0000
Administration: Save column visibility on small screens.
Modifies the jQuery selector for determining hidden columns to ensure they are detected when the expanded columns details are closed.

Adds high-specificity selectors specifically for setting screen options in the comments and plugins lists.

Props afercia.
Fixes #46005. 



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ffead81
svn: r44721
58 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-31 03:31:59 +0000
Post WordPress 5.1 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 819b2d3
svn: r44720
59 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-31 03:16:06 +0000
WordPress 5.1 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4b8e33f
svn: r44719
60 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-30 14:30:42 +0000
Build/Test Tools: Move `WP_UnitTestCase_Base::assertPostConditions()` to a more appropriate place.
See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1f809d9
svn: r44718
61 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-30 14:11:01 +0000
TinyMCE: fix external references in `wpview` and `wpemoji` plugins in the Classic Block instance when running from `/build`.
Fixes #46147.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0612ea2
svn: r44717
62 of 1494
Author
Felix Arntz <[email protected]> 2019-01-30 11:00:30 +0000
Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.
Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a95cec1
svn: r44716
63 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-30 10:06:47 +0000
TinyMCE: update alternative icon fonts for older browsers after [44713].
See #46094.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b9b66b1
svn: r44715
64 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-30 00:53:52 +0000
Build/Test Tools: Simplify `WP_PHPUnit_Util_Getopt` and update documentation.
Introduced in [918/tests] and updated in [26871], the class is there to make sure that known bugs are not skipped when `phpunit` is called with a `--group` that corresponds to an `@ticket` annotation (such as `phpunit --group 12345`).

Enforcing recognized arguments or correctly formed arguments is not the concern here, so reusing `PHPUnit_Util_Getopt::parseLongOption()` was superfluous.

See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 99450a4
svn: r44714
65 of 1494
Author
Peter Wilson <[email protected]> 2019-01-29 21:28:57 +0000
Customize: Remove `wp_targeted_link_rel` pre-save filter from change-sets.
The pre-save filters added to links in [43732] could invalidate JSON data when saving Customizer change-sets.

This removes the filters when saving and publishing change-sets.

Props peterwilsoncc, nikeo for testing.
See #45292.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ca96ccc
svn: r44713
66 of 1494
Author
Ella Van Durpe <[email protected]> 2019-01-29 20:18:33 +0000
TinyMCE: Update to 4.9.2
https://github.com/tinymce/tinymce-dist/compare/4.8.0...4.9.2

Fixes #46094.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: dce18c1
svn: r44712
67 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-29 19:09:22 +0000
Comments: Restore a removed fieldset legend after [44466].
In the Edit Comment page:
- moves the "Author" `h2` heading out of the form fieldset
- removes an unnecessary `<span>` element
- adds a visually hidden legend element to the fieldset
- uses an existing string "Comment Author"

Fixes #43586.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 23c0dd4
svn: r44711
68 of 1494
Author
Riad Benguella <[email protected]> 2019-01-29 18:22:45 +0000
Block Editor: Update WordPress Packages to the latest versions.
Updated Packages:

 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Fixes list block indentation and Crowdsignal embed block.

Props iseulde.
Fixes #46137.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9efcfbb
svn: r44710
69 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-29 01:19:30 +0000
Tests: Fix the tests for the `c` and `r` formats in `date_i18n()`.
To test the `date_i18n()` output correctly, the tests added in [43434] need to set a non-UTC timezone.

Props Rarst.
Fixes #20973.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7497d51
svn: r44709
70 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-28 21:58:40 +0000
Script Loader: Add missing semicolon.
Fixes #46131.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6a680c8
svn: r44708
71 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-28 21:54:48 +0000
Privacy: Use `label_count` property of post status for request counts in the list table views.
See #44952.
Fixes #46112.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6e80f7c
svn: r44707
72 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 18:49:22 +0000
Build/Test Tools: Don't throw an exception for unrecognized options in `WP_PHPUnit_Util_Getopt::parseLongOption()`.
The method is only used for two known options: `group` and `exclude-group`, others should be passed to PHPUnit.

Props johnbillion.
See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4254a35
svn: r44706
73 of 1494
Author
Felix Arntz <[email protected]> 2019-01-28 17:42:55 +0000
Bootstrap/Load: Fix notice when theme directories are not populated yet.
When a fatal error occurs outside of a regular plugin in a stage where theme directories are not set up yet (for example in a MU plugin), this would previously trigger a notice.

Props johnbillion.
Fixes #46068. See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ad71116
svn: r44705
74 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 17:20:06 +0000
Coding Standards: Replace spaced indentation sections of `phpunit.xml.dist`, `multisite.xml`, and `build.xml` with tabs.
Props netweb, desrosj.
See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e481318
svn: r44704
75 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 17:19:14 +0000
Build/Test Tools: Reorder `<file>` and `<exclude>` rules in `multisite.xml` to avoid warnings in PHPUnit 7.2+.
Missed in [44702].

See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 48070a4
svn: r44703
76 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 16:53:14 +0000
Build/Test Tools: Correct `WP_Test_REST_Schema_Sanitization::test_type_string()` to check for both `1.1` float and `'1.10'` string explicitly.
Previously, the test only passed due to a bug in PHPUnit 7.1.x and older versions.

Fixes #43218. See #38586.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6d86370
svn: r44702
77 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 15:54:47 +0000
Build/Test Tools: Reorder `<file>` and `<exclude>` rules in `phpunit.xml.dist` to avoid warnings in PHPUnit 7.2+.
Remove deprecated `logIncompleteSkipped` option that does not exist in PHPUnit 6.0+.

See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 001c649
svn: r44701
78 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-28 14:10:24 +0000
Build/Test Tools: Add support for PHPUnit 7.x.
* Create an abstract `WP_UnitTestCase_Base` class to share between PHPUnit 7.x and older versions.
* Add a speed-trap loader to determine which `SpeedTrapListener` class needs to be loaded for the current PHPUnit version.
* Remove unnecessary `PHPUnit\Util\Test` and `PHPUnit_Util_Getopt` inheritances.
* Update Travis CI config to use PHPUnit 7.x for PHP 7.1, 7.2, and nightly PHP versions.

Props jipmoors, netweb, desrosj, ayeshrajans, soulseekah, SergeyBiryukov.
See #43218.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 639f66a
svn: r44700
79 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-27 14:45:42 +0000
Install/Upgrade: After [44451], update translator comments to include the new placeholder.
See #46111.
Fixes #45574.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fd5f5ae
svn: r44699
80 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-26 12:58:11 +0000
TinyMCE Classic Block: Remove unused variable.
See #46071.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d763cdf
svn: r44698
81 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-26 12:28:15 +0000
REST API: Prevent translating the hook name in a `_doing_it_wrong()` message by using a placeholder.
See #45265.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e01f30a
svn: r44697
82 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-24 11:23:28 +0000
TinyMCE Classic Block: fix repositioning of the inline toolbar on scrolling.
Props iseulde, azaozz.
Fixes #46062.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3b14a06
svn: r44696
83 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-24 11:20:25 +0000
TinyMCE Classic Block: fix the Advanced Link modal (accessible when clicking on the cogwheel in the inline link modal in a Classic Block).
Fixes #46071.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 86d04a5
svn: r44695
84 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-24 11:10:34 +0000
TinyMCE Classic Block: fix the Edit Image modal to work as in the Classic Editor.
Fixes #46085.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ad0a1a2
svn: r44694
85 of 1494
Author
Peter Wilson <[email protected]> 2019-01-23 23:22:23 +0000
Docs: Correct documentation for the `schedule_event` filter.
The filter runs for both recurring and single events.

See #42505.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 554ee5b
svn: r44693
86 of 1494
Author
Peter Wilson <[email protected]> 2019-01-23 23:07:39 +0000
Cron: Move logic for finding the next event's timestamp.
Moves the logic for determining when an event will next run from `wp_next_scheduled()` to `wp_get_scheduled_event()`.

This improves the performance of `wp_get_scheduled_event()` by avoiding duplicate function calls and object cache hits.

Props peterwilsoncc.
Fixes #45976.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 8f94eec
svn: r44692
87 of 1494
Author
Peter Wilson <[email protected]> 2019-01-23 03:38:19 +0000
Plugins: Update docs for individual plugin loaded actions.
Corrects documentation to indicate the full path is passed to each action.

Fixes #41346.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: bb463b5
svn: r44691
88 of 1494
Author
Peter Wilson <[email protected]> 2019-01-22 21:54:26 +0000
Formatting: Prevent `wp_targeted_link_rel()` adding an empty attribute.
Bypass adding a `rel` attribute when the `wp_targeted_link_rel` filter returns an empty string or other falsy result.

Props mcmwebsol, spartank, meatman89fs.
Fixes #45352.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fbe0605
svn: r44690
89 of 1494
Author
Felix Arntz <[email protected]> 2019-01-22 08:51:56 +0000
Bootstrap/Load: Fix fatal error when passing a `WP_Error` to `wp_die()`.
This was introduced in [44466]. Also, this changeset adds tests for `_wp_die_process_input()` so that this never happens again.

Props dd32.
See #45933.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 687590d
svn: r44689
90 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-22 00:56:06 +0000
Post WordPress 5.1 Beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 31bb707
svn: r44688
91 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-22 00:38:42 +0000
WordPress 5.1 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9bd6c81
svn: r44687
92 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-22 00:04:22 +0000
Blocks: Define the `edit_posts` capability on the `wp_block` post type.
Meta capability mapping doesn't recurse through multiple meta definitions, which creates a situation where the capabilities test is looking for the non-existent primitive capability `edit_blocks`, which should instead be mapped to `edit_posts`.

Defining the `edit_posts` capability when the `wp_block` post type is registered causes this check to change to to the `edit_posts` capability.

Props aduth.
Fixes #45373.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 804cb23
svn: r44686
93 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 23:37:57 +0000
Menus: Fix a deprecated call to `get_terms()`.
The taxonomy should be passed as part of `$args`, rather than as its own argument.

Props birgire.
Fixes #45297.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 09066df
svn: r44685
94 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 23:31:45 +0000
Menus: Show an appropriate message when no menus exist.
Props garrett-eclipse.
Fixes #45155.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5e77c07
svn: r44684
95 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 23:02:39 +0000
Customiser: Prevent JS errors when previewing pages with an `<area>` tag.
The customiser assumes that `<area>` tags will have a `href` attribute, which isn't necessarily true. Now it checks instead of assuming.

Props janthiel, adamsilverstein.
Fixes #45053.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d70c159
svn: r44683
96 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 22:56:31 +0000
Comments: Default the `show_comments_cookies_opt_in` checkbox to enabled.
This also updates the option label, to clarify that it needs to be enabled for comment cookies to work.

Props azaozz, pento, dhavalkasvala, desrosj, pputzer, mirkoschubert, ThemeZee.
Fixes #44736.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: dba1a0f
svn: r44682
97 of 1494
Author
John Blackbourn <[email protected]> 2019-01-21 22:51:07 +0000
Bootstrap/Load: Update the `@since` entry for `wp_die()`.
See #46038


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: db4f745
svn: r44681
98 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 22:45:51 +0000
Comments: Update the message shown when a comment is awaiting moderation.
If the commenter doesn't have cookies set, they won't see the comment preview again. Showing an expanded message will help offset any confusion if they revisit the site later, and their comment is still in moderation, but they can't see it anymore.

Props azaozz, pento.
Fixes #44736.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f5b136b
svn: r44680
99 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 22:09:48 +0000
Menus: Remove error styling when the user addresses the error.
An error is triggered if a Menu Name isn't given when the user attempts to create a menu. When they go back and add a name, the error styling can be removed.

Props ashokrd2013, piyush9100, welcher, afercia.
Fixes #42321.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3f7881b
svn: r44679
100 of 1494
Author
laurelfulford <[email protected]> 2019-01-21 22:07:33 +0000
Twenty Seventeen: Update blockquote alignment on load.
The theme uses JavaScript to check if a right-aligned blockquote is below the sidebar content before pushing it outside of the content area. This was originally only firing on browser resize.

Fixes #40103.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f91ac65
svn: r44678
101 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 21:59:44 +0000
Themes: Return the value of `locate_template()` in functions that call it.
The `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions all call `locate_template()` as their final action, which returns the name of the template being loaded. Returning this value helps handle problems with templates being loaded.

Props tferry.
Fixes #40969.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1d2153b
svn: r44677
102 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 21:51:29 +0000
Media: Add a `$real_mime` parameter to the `wp_check_filetype_and_ext` filter.
This allows more accurate filtering of the filename and extension given to uploaded files.

Props desrosj, Tkama.
Fixes #45707.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4052571
svn: r44676
103 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-21 21:12:23 +0000
I18N: Enable `clear_destination` in upgrader for updating/installing language packs.
Introduces `Language_Pack_Upgrader::clear_destination()` to clear existing translations before installing new translations. Ensures that unused translations in JSON format are cleaned up.

Props dd32, swissspidy, ocean90.
Fixes #45468.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 51726c6
svn: r44675
104 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-21 20:40:56 +0000
I18N: Remove JSON translations when deleting a theme or a plugin.
See #29860.
Fixes #45467.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2caa621
svn: r44674
105 of 1494
Author
Felix Arntz <[email protected]> 2019-01-21 20:14:56 +0000
Bootstrap/Load: Change `shutdown handler` naming to final `fatal error handler` and allow disabling the handler entirely via a constant.
The `WP_Shutdown_Handler` name plus related function names were premature when originally committed, as there can be multiple shutdown handlers in PHP, and WordPress makes use of that feature. This changeset modifies the name to a more appropriate `WP_Fatal_Error_Handler`, and related to that changes the following names:

* The drop-in to override the handler is now called `fatal-error-handler.php`.
* The internal function `wp_register_premature_shutdown_handler` is now called `wp_register_fatal_error_handler()`.

In addition to these naming changes, a new constant `WP_DISABLE_FATAL_ERROR_HANDLER` is introduced that can be set in `wp-config.php` to entirely disable the fatal error handler. That constant's value is and should be accessed indirectly via a new `wp_is_fatal_error_handler_enabled()` function and is filterable via a new `wp_fatal_error_handler_enabled` hook. Note that disabling the fatal error handler will skip the new functionality entirely, including the potentially used `fatal-error-handler.php` drop-in.

The new set of constant, filter and function provide for an easier-to-use mechanism to disable the fatal error handler altogether, rather than requiring developers to implement a drop-in for purely that purpose.

Props afragen, flixos90, joyously, knutsp, markjaquith, ocean90, schlessera, spacedmonkey.
Fixes #46047. See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 43bbbbf
svn: r44673
106 of 1494
Author
Felix Arntz <[email protected]> 2019-01-21 20:06:24 +0000
Bootstrap/Load: Fix bug causing AJAX functions to return a 500 when passing a `null` response to `wp_die()`.
This bug was introduced in [44497].

Props ocean90.
See #45933.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 44ce02e
svn: r44672
107 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-21 19:56:47 +0000
PHPCS: Fix formatting issues introduced in [44670].
See #44914.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 50d4abc
svn: r44671
108 of 1494
Author
Felix Arntz <[email protected]> 2019-01-21 19:09:23 +0000
Bootstrap/Load: Ensure that the fatal error shutdown handler does not prevent other shutdown handlers from being called.
This changeset adds support for a new `wp_die()` argument `exit`, which defaults to true and determines whether `wp_die()` should actually terminate the request. The new fatal error handler then calls `wp_die()` with that argument set to false, as calling `die()` or `exit` from a PHP shutdown function prevents other shutdown functions from being called.

Props schlessera, johnbillion.
Fixes #46038. See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 8fe01c0
svn: r44670
109 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-21 18:04:55 +0000
Post Formats: Prevent Bulk Edit from unintentionally changing post format to Standard even if set to "No change".
Correct the logic in [41187].

Props birgire, mukesh27, lanche86.
Fixes #44914. See #41396.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 95c496b
svn: r44669
110 of 1494
Author
laurelfulford <[email protected]> 2019-01-21 18:02:58 +0000
Twenty Seventeen: Prevent YouTube videos from being cut off in Safari.
The theme's `object-fit: cover` styles for the header caused YouTube videos to be positioned too far left in Safari. 

Fixes #40522.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: c0a1cf2
svn: r44668
111 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-21 17:35:00 +0000
Privacy: Include request counts inline with the filters in the list table views.
Fixes $44952
Props eArtboard, pratikkry, birgire, garrett-eclipse.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 59e31e0
svn: r44667
112 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-21 16:07:40 +0000
Docs: Correct type and description for the first parameter of `set-screen-option` filter.
Props pbiron, burhandodhy.
Fixes #44850.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 562ef09
svn: r44666
113 of 1494
Author
Felix Arntz <[email protected]> 2019-01-21 16:01:53 +0000
Bootstrap/Load: Support `WP_Error` and `$args` passed to `wp_die()` consistently in all handlers.
Prior to this change, each `wp_die()` handler had their own logic for how to parse arguments, causing inconsistencies and even breakage because the arguments possible to pass to `wp_die()` depended on the request context. Passing a `WP_Error` as `$message` for example used to be only support by the default handler, but not the AJAX and XML-RPC handlers.

With the fatal error protection, plus the new `wp_die()` handlers related to that, improving this support and compatibility has become more significant. Therefore this changeset introduces a private `_wp_die_process_input()` function that handles all function parameters consistently.

Props spacedmonkey, flixos90, schlessera.
Fixes #45933. See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 8b4330b
svn: r44665
114 of 1494
Author
Sergey Biryukov <[email protected]> 2019-01-21 13:53:33 +0000
I18N: Update translator comment for the notice displayed when viewing the block editor with JavaScript disabled.
A URL in the comment creates an impression that the link is not translatable.

See #45453, #45856.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b7794e6
svn: r44664
115 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 04:59:55 +0000
Dev Tools: Load the `wp-admin` build instructions from `src`.
This de-duplicates the content, so it only needs to be modified in one place.

Additionally, we now link to the NPM/Grunt install guides on the build instructions page.

Props pento, ocean90.
Fixes #43732.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5d7089f
svn: r44663
116 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 04:49:06 +0000
Terms: Show error colours when a term fails to update.
Props birgire, afercia, jaymanpandya.
Fixes #43703.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7d8ce1e
svn: r44662
117 of 1494
Author
Peter Wilson <[email protected]> 2019-01-21 04:26:33 +0000
Options: Avoid unnecessary DB calls when updating network options.
Adds a `maybe_serialize()` comparison for the old and new values in `update_network_option()` to avoid unnecessary database writes when options contain identical objects.

Props bor0.
Fixes #44956.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 02422aa
svn: r44661
118 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 04:12:10 +0000
Widgets: Fix Gallery Widget preview after an image is deleted.
The Gallery Widget incorrectly tried to include the deleted image in the preview.

Props westonruter, janak007, afercia, mrasharirfan.
Fixes #43139.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3ea21b6
svn: r44660
119 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 01:44:49 +0000
Docs: Improve the docblocks for `wp_insert_post()` and `wp_set_post_categories()`.
Their respective `post_category` and `post_categories` parameters were not correct.

Props Takahashi_Fumiki.
Fixes #45171.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9dfde99
svn: r44659
120 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 01:33:50 +0000
Comments: Show the "awaiting moderation" message when comment cookies are disabled.
The "Your comment is awaiting moderation." message relied upon the comment author cookie being set. However, since it's now possible to opt-out of that cookie, submitting a comment won't show the comment preview when the comment is placed in moderation.

To avoid this issue, we now include a hash in the redirect URL, allowing the site to identify that a preview of the moderated comment should be displayed.

Props imath, tomdxw, birgire, lakenh, azaozz, pento.
Fixes #43857.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 19645a4
svn: r44658
121 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-21 00:32:33 +0000
Tests: Add tests for the `__return*()` functions.
Props pbearne, mukesh27.
Fixes #46043.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 192224a
svn: r44657
122 of 1494
Author
laurelfulford <[email protected]> 2019-01-20 20:22:05 +0000
Twenty Nineteen: Create separate `:lang()` selectors for Devanagari.
In the non-latin font fallback styles, languages using the Devanagari alphabet were initially committed in a comma-separated list in the `:lang()` selector, which isn't fully supported. This update separates those languages into their own `:lang()` selectors. 

Props mako09.
Fixes #45731.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f518dea
svn: r44656
123 of 1494
Author
Felix Arntz <[email protected]> 2019-01-20 12:02:02 +0000
Upgrade/Install: Make `version_compare()` calls for plugin required version checks more robust.
Props afragen.
Fixes #46024. See #43986.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6dde7cd
svn: r44655
124 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-19 15:27:11 +0000
Build/Test Tools: Update QUnit index file after [43174].
Updates the last occurrence of "(opens in a new window)" to "(opens in a new tab)".

See #43803.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d7ecd67
svn: r44654
125 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-19 10:22:16 +0000
TinyMCE: fix `$_old_files` after [44651], remove `wp-tinymce.js` and add `wp-tinymce.js.gz`.
Props ocean90, garrett-eclipse.
Fixes #45645.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 544e7a3
svn: r44653
126 of 1494
Author
Mike Schroder <[email protected]> 2019-01-19 01:19:18 +0000
Media: Port date filter width fix from Gutenberg.
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in https://github.com/WordPress/gutenberg/commit/8deaf5eca672848224e286e0ab03dde40fd5219d in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See https://github.com/WordPress/gutenberg/issues/2202

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7c0a304
svn: r44652
127 of 1494
Author
laurelfulford <[email protected]> 2019-01-18 20:45:34 +0000
Twenty Nineteen: Fix alignment of page title when there are no posts.
Fix the alignment of the "Nothing Found" page title when there are no posts, to match how it appears for the search results when nothing is found, and the 404 page. 

Props kjellr, lorenzone92.
Fixes #45887.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 21e479d
svn: r44651
128 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-18 19:50:19 +0000
TinyMCE: retire wp-tinymce.php and remove pre-compression of wp-tinymce.js.
Fixes #45645.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1311424
svn: r44650
129 of 1494
Author
laurelfulford <[email protected]> 2019-01-18 18:37:26 +0000
Twenty Nineteen: Use a less aggressive approach for non-latin font fallbacks.
The theme's original approach to its non-latin font fallbacks required `!important`, which overrode fonts that shouldn't have been changed, like the icon fonts used for editor buttons.

Props kjellr, mako09, allancole.
Fixes #45731.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b3a658e
svn: r44649
130 of 1494
Author
Andrew Ozz <[email protected]> 2019-01-18 16:32:46 +0000
TinyMCE: treat HTML comments same as tags when keeping cursor position. Fixes breaking the More and Nextpage tags when switching from Text to Visual.
Props iCaleb, jeremeylduvall.
Fixes #45947.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3132f22
svn: r44648
131 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 05:25:48 +0000
Block Editor: Restore the Custom Fields display option.
When merging, [44244] and [44260] were committed to trunk the opposite way that they were committed to the 5.0 branch. They were originally committed in [43885] and [43861], respectively.

Due to this switch, a change in how the Custom Fields meta box was registered wasn't merged from the 5.0 branch, causing it to not be registered correctly in trunk.

Props dd32, pento.
Fixes #46028.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7521e95
svn: r44647
132 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 04:03:20 +0000
Coding Standards: Remove some `add_action()`s that were commented out years ago.
Props Girishpanchal.
Fixes #44545.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 22ac9a3
svn: r44646
133 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 04:02:17 +0000
Plugin Installer: Ensure CSS for the 3-column view isn't applied to the 4-column view.
Props nielslange.
Fixes #43573.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2ec6c8f
svn: r44645
134 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 02:14:24 +0000
Build Tools: Upgrade WPCS to 2.0.0.
A few sniffs have been renamed, this change includes the relevant `phpcs:ignore` comment updates.

Fixes #46002.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d3ee420
svn: r44644
135 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 01:41:41 +0000
Emoji: Upgrade Twemoji to 11.2.0.
This upgrade includes general improvements to the style of a variety of emoji.

Full changelog: https://github.com/twitter/twemoji/compare/v11.0.0...v11.2.0

Props desrosj, pento.
Fixes #45133.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 73cbf3e
svn: r44643
136 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-18 01:02:11 +0000
Docs: Add missing periods to a grab-bag of docblocks.
Props Hitendra Chopda.
Fixes #45409.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3e390cd
svn: r44642
137 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-17 21:44:30 +0000
Tests: Do not include the delimiter parameter in `ucwords()` calls.
This parameter is not supported in PHP < 5.4. Introduced in [44641].

See #44672.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 83cfc77
svn: r44641
138 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-17 21:24:47 +0000
REST API: Allow a user to change the letter casing of their email.
When a `PUT` request is performed to update a user, a `rest_user_invalid_email` error is incorrectly being returned when the email exists with different letter casing, even if it belongs to the user being updated. `email_exists()` performs a case insensitive lookup, but the conditional statement following that lookup was performing a strict comparison between the new email and the user’s current email.

This changes that comparison to instead compare the user ID returned by `email_exists()` with the user ID being updated. This more closely matches the logic used in `edit_user()` and allows a user to change the letter casing of their email.

Props fuchsws, rachelbaker, desrosj.
Fixes #44672.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a0978e8
svn: r44640
139 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-17 12:07:32 +0000
Media: Improve unselecting media in the media bulk selection mode.
Disables the "Delete Selected" button when unselecting media by clicking the
"checkmark" box in the media bulk selection mode.

Props subrataemfluence, adamsilverstein.
Fixes #42239.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6b489bb
svn: r44639
140 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-17 11:54:23 +0000
Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends.
When Internet Explorer encounters a non interactive element with a `tabindex`
attribute, it adds the element to the accessibility tree with a `role=group` and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.

- removes `tabindex="0"` from the content and the toolbar containers: these tabindex attributes are no longer needed
- removes `aria-label="Main content"` from the content container: not needed
- keeps the media modal focus fallback introduced in [38142] by making the `#wpbody-content` element focusable only when needed

Props stevefaulkner, aardrian.
Fixes #43154.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b71875d
svn: r44638
141 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 07:56:32 +0000
Docs: Partial revert of [44636].
Unrelated changes in `wp-includes/general-template.php` were accidentally committed.

See #44502.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fb37359
svn: r44637
142 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-17 07:40:40 +0000
Administration: CSS coding standards
- properties should be followed by a colon and a space
- media queries shouldn't use spaces within parenthesis
- indentation should use tabs instead of spaces or mixed spaces / tabs
- the content property should use double quotes
- no double spaces

Props nadim0988, afercia.
Fixes #45185.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 15f4df2
svn: r44636
143 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 07:20:16 +0000
Docs: Mark the internal functions as `@private` in `wp-includes/post.php`.
Props shamim51.
Fixes #44502.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: bcba20d
svn: r44635
144 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 06:45:58 +0000
Docs: Fix the last handful of incorrect `@since 5.0.0` docblock tags.
Props peterwilsoncc.
Fixes #45543.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7303470
svn: r44634
145 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 06:26:05 +0000
Media: `media_handle_sideload()` expectes `wp_insert_attachment()` to return a `WP_Error`.
For `wp_insert_attachment()` to do that, we need to be setting the `$wp_error` parameter to true.

Props subrataemfluence, jirihon.
Fixes #44303.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2e63f69
svn: r44633
146 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 04:33:42 +0000
Tests: Ensure meta keys are cleaned up after each test.
Props jnylen0.
Fixes #46007.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 37dd83a
svn: r44632
147 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 04:23:38 +0000
Build Tools: Uglify `underscore.min.js` while building.
This avoids a `sourceMappingURL` being in the minified file, as we don't ship source maps.

Props pento, laghee.
Fixes #44560.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a3fe5b7
svn: r44631
148 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 02:44:32 +0000
Comments: Correct the "Mine" comment count when viewing comments for a particular post.
The count should only be comments made on that post by the current user, not all comments by them.

Props chetan200891, garrett-eclipse.
Fixes #46014.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9505624
svn: r44630
149 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-17 00:48:59 +0000
Coding Standards: Remove an assignment in a conditional from `get_plugins()`.
Props subrataemfluence.
Fixes #44249.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6f6b23d
svn: r44629
150 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-16 22:44:25 +0000
Privacy: Improve the ’Copy’ button verbiage to provide more clarity.
On the Privacy Policy Guide, there is currently a ‘Copy’ button below each section of suggested text. It is unclear what copy means without more context. It could be assumed, for instance, that the suggested text is copied to a new page.

This changes the button text to read `Copy this section to clipboard` to more clearly inform the user what is copied and how.

Props JoshuaWold, garrett-eclipse, birgire, vishaldodiya.
Fixes #44677.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0637182
svn: r44628
151 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-16 17:51:56 +0000
Privacy: Allow column sorting in the privacy request admin tables.
This allows users to sort the export and erase personal data request tables by “Requester” (`post_title`, or user email) and “Requested” (`post_date`, or when the request was created), which can be helpful when sites have many requests present.

Props birgire, ianbelanger, pbiron, desrosj.
Fixes #43405.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 17e5f4a
svn: r44627
152 of 1494
Author
Felix Arntz <[email protected]> 2019-01-16 17:05:37 +0000
Plugins: Use centralized API to display information about updating PHP when a plugin requires a higher version.
This changeset uses the API functions introduced in [44476] to link to the resource about updating PHP when highlighting a plugin's required PHP version is not met. It furthermore expands them, introducing a new `wp_update_php_annotation()` function that prints the markup to indicate that the default URL has been altered by the web host, allowing it to be reused universally.

Furthermore, this changeset adds missing `update_php` capability checks before displaying the information about updating PHP.

Props afragen.
Fixes #45986. See #43986, #45686.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4e9dacc
svn: r44626
153 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-16 16:50:15 +0000
Coding Standards: Manually fix coding standards violations in `wp-signup.php`.
Props GaryJ, jrf, netweb, desrosj.
Fixes #43405.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 34bd90a
svn: r44625
154 of 1494
Author
Felix Arntz <[email protected]> 2019-01-16 15:21:49 +0000
Bootstrap/Load: Add support for JSON requests to `wp_die()`.
In addition to AJAX and XML-RPC requests, `wp_die()` now handles JSON requests correctly, returning information in the expected content type.

Props spacedmonkey.
See #45933, #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 633a444
svn: r44624
155 of 1494
Author
Felix Arntz <[email protected]> 2019-01-16 15:20:04 +0000
Bootstrap/Load: Fix workaround to display admin link in PHP error template by introducing `$link_url` and `$link_text` arguments to `wp_die()`.
This changeset removes the hack that was used before to display more complex HTML markup than a simple message in the default PHP error template via `wp_die()`. By removing HTML markup from the arguments passed to `wp_die()` it furthermore paves the way for supporting other content types than the default.

The message and arguments can be modified with new `wp_php_error_message` and `wp_php_error_args` filters respectively.

Furthermore this changeset fixes a few issues of functions not existing which could potentially have caused fatal errors when executed early in the WordPress bootstrap process.

Props flixos90, spacedmonkey.
See #45933, #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 33f524f
svn: r44623
156 of 1494
Author
Felix Arntz <[email protected]> 2019-01-16 14:03:35 +0000
Bootstrap/Load: Only pause extensions when they cause a crash on a protected endpoint.
This is a first step on pausing extensions less aggressively. If a plugin or theme only causes a crash in the frontend, there is no point in pausing it in the admin backend.

See #45940, #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 72e86aa
svn: r44622
157 of 1494
Author
Felix Arntz <[email protected]> 2019-01-16 13:33:56 +0000
Bootstrap/Load: Use `wp_load_translations_early()` when Translation API is not yet loaded.
Props spacedmonkey.
Fixes #45932. See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 00726f0
svn: r44621
158 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-16 12:58:45 +0000
Taxonomy: Remove extra padding around buttons on term edit page.
Props monikarao, mukesh27, chetan200891.
See #9777.
Fixes #45183.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fdd285c
svn: r44620
159 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 06:15:40 +0000
Docs: Improve the `sanitize_email` filter.
- Remove duplicate parameter names.
- Fix the wrong value being passed in the second parameter.
- Correct the type of the `$message` parameter.

Props ChriCo.
Fixes #45595.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 989425c
svn: r44619
160 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 06:09:27 +0000
Rewrite: Remove extra arguments being passed to `WP_Rewrite::iis7_url_rewrite_rules()`.
Props rafsuntaskin.
Fixes #44185.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: afa5512
svn: r44618
161 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 06:04:51 +0000
Formatting: Add type checking to `_sanitize_text_fields()`.
When a non-string value is passed, return an empty string.

Props Mte90.
Fixes #41450.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 267c79a
svn: r44617
162 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 06:00:23 +0000
Plugin Editor: Disable the documentation look up button when no function is selected.
Props xkon.
Fixes #41143.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: cd7d022
svn: r44616
163 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 05:53:26 +0000
Templates: Fix the return value of `get_the_author_posts_link()`.
When the `$authordata` global isn't defined, return an empty string, rather than `void`.

Props mukesh27, subrataemfluence.
Fixes #45597.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 97c6a43
svn: r44615
164 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 05:40:04 +0000
Admin: Use `is_user_logged_in()` instead of `wp_validate_auth_cookie()` in `admin-post.php`.
This matches the authentication check in `admin-ajax.php`, and allows the authentication method to be filtered.

Props jmdodd.
Fixes #45475.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9beaad7
svn: r44614
165 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 05:35:27 +0000
Docs: Correct the docs for `POMO_Reader::setEndian()`.
The parameter type and name where the wrong way around.

Props ishitaka.
Fixes #45410.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5d52753
svn: r44613
166 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 05:31:29 +0000
Docs: Correct the `@return` type of `get_theme_mod()`.
This now matches the type of the `$value` parameter of `set_theme_mod()`.

Props mensmaximus.
Fixes #45319.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e23ffe3
svn: r44612
167 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 05:28:56 +0000
Docs: Remove duplicate docblocks for the `pre_user_login` and `link_category` filters.
Props coffee2code.
Fixes #45308.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e79bddc
svn: r44611
168 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 04:26:48 +0000
Users: Add extra checking to `wp_new_user_notification()`.
Prevent a notification from being sent when an unrecognised value is passed in the `$notify` parameter.

Props cthreelabs, 360zen.
Fixes #44293.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5aeabd7
svn: r44610
169 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 03:53:42 +0000
Posts: Set a HTTP 403 error when an incorrect post preview nonce is sent.
Props graymouser.
Fixes #43570.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: efcc69e
svn: r44609
170 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 03:37:38 +0000
Docs: Add documentation for the `wp_maybe_auto_update` action.
Props MikeGillihan.
Fixes #43301.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: c2862a4
svn: r44608
171 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-16 02:53:15 +0000
Admin Bar: Set the Admin Bar to not be showing on REST API requests.
Props ayeshrajans.
Fixes #45727.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 99bcf27
svn: r44607
172 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-15 22:47:14 +0000
Docs: Add missing documentation for `_WP_Dependency::set_translations()`.
Introduced in [43859].

Props stazdotio.
Fixes #45550.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3f4cc1a
svn: r44606
173 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-15 22:34:39 +0000
Privacy: Use consistent variable naming when working with privacy requests.
Throughout the core privacy functions, `WP_User_Request` instances were stored in variables named both `$request`, and `$request_data`. This changes all occurrences of `$request_data` to `$request` for better consistency.

Props nateallen, bruceallen, garrett-eclipse.
Fixes #44708.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: efc09a6
svn: r44605
174 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 10:28:42 +0000
Docs: Tweak the docblock for `setup_userdata()`.
This is a followup to [44603]. The default value should be last, not somewhere in the middle.

Props swissspidy.
Fixes #44697.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a90d82f
svn: r44604
175 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-15 07:47:27 +0000
Admin: Use the correct CSS media query for the Help tab on small screens after [44588].
See #43221


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3a6ffa1
svn: r44603
176 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 06:32:21 +0000
Users: Correct the default value in `setup_userdata()`.
The `$for_user_id` parameter is an `int`, not a `string`, so the default value should be `0`, rather than an empty string.

Props subrataemfluence.
Fixes #44697.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0393473
svn: r44602
177 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 06:26:23 +0000
Users: Check that a valid user is passed to `get_password_reset_key()`.
Props edocev.
Fixes #44601.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: de1b02f
svn: r44601
178 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 06:17:42 +0000
Docs: Fix the `WP_Object_Cache::get()` docblock.
The `$force` parameter is a `bool`, not a `string`. The matching `wp_cache_get()` docblock has the correct type.

Props subrataemfluence.
Fixes #44454.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: c1ae8b9
svn: r44600
179 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 05:53:35 +0000
Docs: Add docblocks for `WP_Customize_Header_Image_Control` member variables.
Props subrataemfluence.
Fixes #44410.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0c9236a
svn: r44599
180 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 05:48:46 +0000
Build Tools: Don't send AppVeyor notifications on Slack on repeated successful builds.
See #44276.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: bb59882
svn: r44598
181 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 05:47:04 +0000
Coding Standards: Move an assignment out of a condition in `wp-admin/admin.php`.
Props subrataemfluence, jrf, pento.
Fixes #44363.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: da17f41
svn: r44597
182 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 05:37:48 +0000
Coding Standards: Move assignments out of conditions in `wp-includes/user.php`.
Props subrataemfluence.
See #44315.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 65d6dd1
svn: r44596
183 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 05:19:59 +0000
Updates: Tweak the "before updating, please back up..." message.
Props chetan200891, [email protected]
See #43790.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e878173
svn: r44595
184 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 04:50:03 +0000
Build Tools: Tweak AppVeyor settings.
- Set `grunt build` as the build script
- Disable testing and deployment options
- Customise the Slack integration message
- Only show the Slack message when the status changes

See #44276.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6dbb675
svn: r44594
185 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 04:20:10 +0000
Build Tools: Add AppVeyor integration.
AppVeyor allows us to test in a Windows environment. This first iteration tests that building works correctly.

Props netweb.
Fixes #44276.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 66eefd6
svn: r44593
186 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-15 02:40:59 +0000
Coding Standards: Assignments must be the first block of code on a line.
Props subrataemfluence.
Fixes #44225.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 425b59c
svn: r44592
187 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-15 02:07:41 +0000
Docs: Update inaccurate `return` descriptions.
In the `@return` tag description for `get_post_modified_time()`, `get_the_time()`, and `get_post_time()`, the `$d` parameter is incorrectly referred to as `$id`.

Props behzod.
Fixes #45323.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f418ee1
svn: r44591
188 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 01:53:02 +0000
Link Template: In `get_adjacent_post()`, move the sanitisation of `$excluded_terms` earlier.
This is a followup to [42828], ensuring that the `get_{$adjacent}_post_excluded_terms` filter is always passed an array, as expected.

Props soulseekah, zottto.
Fixes #43521.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d7e86e8
svn: r44590
189 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 00:51:44 +0000
Docs: Update the `@since` version for the `doing_it_wrong_trigger_error` filter.
Fixes #34183.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e121a5e
svn: r44589
190 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 00:42:30 +0000
Widgets: Remove unnecessary `sanitize_text_field()` calls in core widget `::form()` methods.
This sanitisation only needs to be run in `::update()` to correctly clean up the input.

Props welcher, greenshady.
Fixes #42461.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 580d483
svn: r44588
191 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-15 00:19:54 +0000
Admin: Make the Help tab available on small screens.
Props jobthomas, xkon.
Fixes #43221.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 5cdc0e1
svn: r44587
192 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 23:26:20 +0000
Query: Cache the result when `get_pages()` doesn't find anything in the database.
Props flixos90, soulseekah.
Fixes #43514.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 464c9a7
svn: r44586
193 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 23:11:20 +0000
Docs: Improve the docblock of `wp_admin_bar_edit_menu()`.
What age were you when you learned that there's a `$user_id` global, as well as `$user_ID` global? I was today years old.

Props pento, mukesh27.
Fixes #43448.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 25ffb39
svn: r44585
194 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 23:00:05 +0000
Docs: Improve documentation of the ``$wp_registered_sidebars` global.
Props mukesh27.
Fixes #43448.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: dd85c35
svn: r44584
195 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-14 21:33:56 +0000
Tests: Add missing `parent::tearDown()`.
Also, remove a `tearDown()` method that was not serving any purpose.

Fixes #45931.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: c803256
svn: r44583
196 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 07:24:16 +0000
Customizer: Use the `sandbox` attribute to prevent top navigation from the preview.
Props valchovski.
Fixes #42341.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 065e781
svn: r44582
197 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 07:22:03 +0000
Customizer: Fix a coding standards issue introduced in [44580].
See #40020.




git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7de2138
svn: r44581
198 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 06:53:44 +0000
Docs: Improve docblocks for `_get_plugin_data_markup_translate()` and `_sort_uname_callback()`.
Props Jaydeep Rami.
Fixes #42228.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f5f5da1
svn: r44580
199 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 06:37:30 +0000
Customizer: Improve browser compatibility of the preview iframe.
When `home` and `siteurl` are different, the customizer preview iframe will be blank in Chrome and Safari, due to their `X-Frame-Options` implementation quirks.

Changing this to `SAMEORIGIN` and adding the `frame-ancestors` Content Security Policy gives the correct behaviour.

Props fullyint.
Fixes #40020.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 71abc20
svn: r44579
200 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 05:38:41 +0000
Formatting: Remove soft hyphens when sanitising titles.
Props andg.
Fixes #45378.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4550488
svn: r44578
201 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 05:04:12 +0000
Widgets: Don't log invalid HTML in the Text Widget.
[41215] supresses these irrelevant error messages from the front end, this removes them from the error log, too.

Props jeherve.
Fixes #43815.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e547ecc
svn: r44577
202 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 04:54:01 +0000
Tests: Add missing `parent::setUp()` calls to all test classes.
Props johnbillion, birgire.
Fixes #37375.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f73d8da
svn: r44576
203 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-14 01:46:56 +0000
Blocks: Add a `$source_block` parameter to the `render_block_data` filter.
This contains a copy of the block, unmodified by other filter functions, so that plugins have a clean reference to work from, if they need.

Props dmsnell.
Fixes #45451.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 627ce6f
svn: r44575
204 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-12 15:00:04 +0000
Accessibility: Exclude the Windows High Contrast mode transparent outline from the CSS transition after [44544].
See #41286.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 992184c
svn: r44574
205 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 06:40:16 +0000
Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a139c8c
svn: r44573
206 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 06:05:55 +0000
Coding Standards: Fix and whitelist variable names.
From the `WordPress.NamingConventions.ValidVariableName` sniff, this commit fixes/whitelists all `NotSnakeCaseMemberVar`, `MemberNotSnakeCase`, and `StringNotSnakeCase` violations. It also fixes a handful of the `NotSnakeCase` violations.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: cf5be80
svn: r44572
207 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 04:52:53 +0000
Coding Standards: Remove an unnecessary line whitelisting.
Props jrf.
See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: c1d4ff4
svn: r44571
208 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 04:00:42 +0000
Coding Standards: Exclude some external files.
- `class-wp-block-parser.php` and `wp-includes/blocks/*` are imported from the Gutenberg plugin.
- `speed-trap-listener.php` is a third party library.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 358d65b
svn: r44570
209 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 03:48:05 +0000
Coding Standards: Fix an incorrect `phpcs:ignore` comment.
It's `phpcs:ignore`, not `wpcs:ignore`.

Props GaryJ.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ff53bd3
svn: r44569
210 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-12 03:19:23 +0000
Coding Standards: Extract `extract()` from the codebase.
Of the last four instances of `extract()` occurring, three of them are removed by this commit, and the fourth is appropriately documented.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 34e3de7
svn: r44568
211 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-11 18:18:41 +0000
REST API: Encourage proper usage of `register_rest_route()`.
Calling `register_rest_route()` too early in the loading process has the potential to cause some unintentional problems and pitfalls. Because `register_rest_route()` calls `rest_get_server()` (which creates the `WP_REST_Server` instance), calling the function directly and/or before `rest_api_init` should be discouraged.

For example, if `register_rest_route ()` is called on `init`, the REST API server instance is set up (and all functions added to `rest_api_init` and other related hooks are invoked), even though the current request may not be a REST request. Also, if `register_rest_route()` is called even earlier (say, in an `mu-plugin` file), required endpoints may be missing since normal plugins have not yet been loaded and have not had a chance to register their own action hooks.

This adds a `_doing_it_wrong()` notice the first time `register_rest_route()` is called before `rest_api_init` in a request to encourage best practices for registering REST API routes.

Props kraftbj, desrosj, timothyblynjacobs.
Fixes #45265.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d78fa59
svn: r44567
212 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-11 13:55:28 +0000
Menus: Make menu items not jump while dragging items.
Props alexvorn2, welcher, afercia.
Fixes #41160.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 33caf61
svn: r44566
213 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 06:39:55 +0000
Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations.
See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 83af032
svn: r44565
214 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 06:25:37 +0000
Coding Standards: Document intentional `case` block fall-throughs.
Fixes `PSR2.ControlStructures.SwitchDeclaration.TerminatingComment` violations.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d0f00b5
svn: r44564
215 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 06:16:35 +0000
Coding Standards: Add exceptions for `WordPress.Files.FileName.NotHyphenatedLowercase`.
See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6f0487c
svn: r44563
216 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 06:07:50 +0000
Coding Standards: Ignore the violations of `Generic.NamingConventions.UpperCaseConstantName.ConstantNotUpperCase`.
See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 8cc4933
svn: r44562
217 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 06:03:46 +0000
Coding Standards: Fix the minor `WordPress.WP.I18n` violations.
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: df77131
svn: r44561
218 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 04:59:23 +0000
Coding Standards: `template.php` isn't a template tag file.
`WordPress.Files.FileName.InvalidTemplateTagFileName` shouldn't apply to it.

See #45934.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 65f5fcb
svn: r44560
219 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 03:44:20 +0000
Coding Standards: Ignore the single WordPress.PHP.RestrictedPHPFunctions.create_function_create_function violation.
This is intentional, for older PHP support.

See #45934.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 63fbf4a
svn: r44559
220 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 03:03:08 +0000
Coding Standards: Remove PHPCS 2.x `@codingStandardsIgnore*` ignore syntax.
Props netweb.
Fixes #42808.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b0c61e2
svn: r44558
221 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 00:58:03 +0000
Post WordPress 5.1 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2792e71
svn: r44557
222 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-11 00:41:39 +0000
WordPress 5.1 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 49f5f62
svn: r44556
223 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 23:39:19 +0000
Emoji: Fix a code formatting error introduced in [44554].
See #45930.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1eaf745
svn: r44555
224 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 23:31:01 +0000
Blocks: Reverse the logic when checking the `pre_render_block` result.
We should be returning if the result isn't null, not when it is.

See #45451.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d32cead
svn: r44554
225 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 23:19:37 +0000
Emoji: Improve performance when encoding or staticizing emoji.
Both `wp_encode_emoji()` and `wp_staticize_emoji()` perform a PHP version check when deciding how to apply their behaviour, but this check only needs to happen once, rather than every time in their internal looks.

Moving the check outside of the loop reduces processing time by 50%.

Props johnbillion.
Fixes #45930.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0414717
svn: r44553
226 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 23:15:49 +0000
Blocks: Add the `pre_render_block` and `render_block_data` filters.
At the start of `render_block()`, the `pre_render_block` filter allows the function to be short-circuited, and the `render_block_data` filter is applied to the `$block` parameter before it's processed.

Props kkarpieszuk, pento.
Fixes #45451.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 7508db6
svn: r44552
227 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 22:41:13 +0000
Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers.
These services no longer support oEmbed.

Props skostadinov, notnownikki.
Fixes #45399.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: b3fcb41
svn: r44551
228 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-10 22:29:46 +0000
Accessibility: Improve text input in the Tags meta box when using Safari + Voiceover.
Props parbaugh, konainm, wbrubaker, pento, ryelle.
Fixes #44966.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2e8b87c
svn: r44550
229 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 22:09:26 +0000
Docs: Add missing periods to `param` annotations for `flip()` in `WP_Image_Editor_GD`.
Props hitendra-chopda.
Fixes #45208.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a0bca4f
svn: r44549
230 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-10 22:07:42 +0000
Accessibility: Improve color contrast ratio in the Events and News dashboard widget.
Props boemedia, lucagrandicelli.
Fixes #45280.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3a6966b
svn: r44548
231 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 21:36:05 +0000
Media: Correct `since` annotation for adding the `caption_id` attribute.
Introduced in [42704]
Fixes #34595.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6cc9452
svn: r44547
232 of 1494
Author
Felix Arntz <[email protected]> 2019-01-10 21:16:49 +0000
General: Fix existing coding standard violations in bookmark tests, as outlined in [44546].
See #43977.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 08564b5
svn: r44546
233 of 1494
Author
Felix Arntz <[email protected]> 2019-01-10 21:05:50 +0000
General: Fix problematic string to array parsing.
WordPress has historically often used code like `preg_split( '/[\s,]+/', $var )` to parse a string of comma-separated values into an array. However, this approach was causing an empty string to not be parsed into an empty array as expected, but rather into an array with the empty string as its sole element.

This was among other areas causing problems in the REST API where passing an empty request parameter could cause that request to fail because, instead of it being ignored, that parameter would be compared against the valid values for it, which typically do not include an empty string.

Props david.binda, sstoqnov.
Fixes #43977.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 238e899
svn: r44545
234 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-10 17:20:59 +0000
Accessibility: Remove negative tabindex from the login, install, and setup pages header.
Props bamadesigner, rishishah, jainnidhi.
Fixes #42632.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2d4ae6c
svn: r44544
235 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-10 16:46:44 +0000
Accessibility: Add focus styles for Windows High Contrast mode.
Introduces in core new focus styles dedicated to Windows High Contrast mode. The 
new styles use a transparent CSS outline as already explored in the Block Editor.
This first part covers some of the main user interface controls like buttons, links,
and media views elements. Other parts will be addressed in the next future.

Fixes #41286.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3b3808f
svn: r44543
236 of 1494
Author
Andrea Fercia <[email protected]> 2019-01-10 16:30:03 +0000
Accessibility: Improve the way Safari and VoiceOver read out the screen reader text.
Sometimes, Safari and VoiceOver read out the text hidden with `screen-reader-text`
in a wrong order. While there's no known, full, solution, it is possible to make 
them respect the correct order reliably at least within buttons.

Fixes #42006.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ba6f1ff
svn: r44542
237 of 1494
Author
Jonathan Desrosiers <[email protected]rdpress.org> 2019-01-10 15:27:09 +0000
Media: Introduce the `has_post_thumbnail` filter.
Props rzen, desrosj.
Fixes #44859.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 9b19f2e
svn: r44541
238 of 1494
Author
Felix Arntz <[email protected]> 2019-01-10 10:45:13 +0000
I18n: Add missing translator comments in `wp-admin/includes/class-wp-plugins-list-table.php`.
Fixes #45898.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 399048f
svn: r44540
239 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 03:30:42 +0000
Docs: Correct `since` annotation for `_wp_get_allowed_postdata()`.
This function was introduced in 5.0.1, not 4.9.9 as currently indicated. Introduced in [44047].

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fa886b2
svn: r44539
240 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 02:56:24 +0000
Admin: Don't use the `keyup` event in addition to the `input` event.
The `keyup` event was used to provide support for IE8, where which doesn't support the `input` event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.

Props dlh, afercia.
Fixes #32882.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1f13137
svn: r44538
241 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 02:49:23 +0000
Docs: Restore `output` annotation in `tags-suggest.js`.
This was mistakenly removed in [44537].

See #38922.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2fe6670
svn: r44537
242 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 02:36:40 +0000
REST API: Restore use of `wp_ajax_ajax_tag_search()` for tag search.
This solution does not work with custom taxonomies in the current state.

Reverts [42614,42619,42737].

Props danielbachhuber.
See #38922.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0394aab
svn: r44536
243 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 02:18:19 +0000
Tests: Add support for a `WP_TESTS_SKIP_INSTALL` environment variable.
Defining `WP_TESTS_SKIP_INSTALL=1` when running tests will skip the install step. While this shouldn't be used for full test runs, it's useful for saving time when running small groups of tests.

Props soulseekah.
Fixes #43432.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0161a5b
svn: r44535
244 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 02:06:44 +0000
Privacy: Add unit tests for privacy erasure fulfillment notifications.
Adds appropriate unit tests for `_wp_privacy_send_erasure_fulfillment_notification()`.

Props birgire, desrosj.
Fixes #44234.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e88eb4a
svn: r44534
245 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 02:03:25 +0000
Build/Tests: Allow running unit tests from `src`.
This is a partial recommit of [44509]: it allows running unit tests from `src` (which is useful), but doesn't make it the default (which Travis is having issues with).

See #45863.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ac47db2
svn: r44533
246 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 01:53:38 +0000
Block Editor: Upgrade the `@wordpress/` packages.
This brings the block editor in core up to date with the Gutenberg 4.8 plugin release.

Props aduth, gziolo, youknowriad, mkaz, jorgefilipecosta, swissspidy, iseulde, soean, noisysocks, joen, brentswisher, dekervit, dimadin, zebulan, johnny5, nosolosw, netweb, ryelle, etoledom, mzorz, desrosj, mmtr86, tinkerbelly, ocean90, earnjam, ajitbohra, talldanwp, notnownikki, mcsf, afercia, adamsilverstein, gutendev, naoki0h, miyauchi, aldavigdis.
Fixes #45885.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 986c85c
svn: r44532
247 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 01:51:39 +0000
PHPCS: Fix formatting issues.
Fixes formatting issues introduced in [44528].

See #42017.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 98e1564
svn: r44531
248 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 01:42:54 +0000
Docs: Update `since` annotation for `text-transform` support in `safecss_filter_attr()`.
Introduced in [42880].

Fixes #42729.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: bb38725
svn: r44530
249 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 01:39:20 +0000
Docs: Update `since` annotation for `comments_list_table_query_args`.
Introduced in [42420].

Fixes #42997.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 3e5aa4d
svn: r44529
250 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-10 01:38:22 +0000
Build Tools: Copy unminified JS files to `src`.
This allows `SCRIPT_DEBUG` to be set to `true` when running from `src`.

Fixes #45869.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 25e9a6d
svn: r44528
251 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-10 01:31:52 +0000
Media: Store audio creation date in meta.
In [41746], `wp_get_media_creation_timestamp()` was introduced to read the created timestamp for videos from `getID3` in meta whenever possible. This information is useful separately from the dates on the file itself.

This adds the same support audio files by utilizing `wp_get_media_creation_timestamp()` in `wp_read_audio_metadata()`.

Props blob folio, desrosj.
Fixes #42017.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: da6021b
svn: r44527
252 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-09 22:41:32 +0000
Docs: Update `since` annotations `WP_Error::has_errors()`
Introduced in [42761].

Fixes #42742.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: d50afa9
svn: r44526
253 of 1494
Author
Felix Arntz <[email protected]> 2019-01-09 21:28:21 +0000
Upgrade/Install: Add missing call to clear site meta cache in `populate_site_meta()`.
See #44896.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ffd2a4b
svn: r44525
254 of 1494
Author
Felix Arntz <[email protected]> 2019-01-09 20:43:57 +0000
Bootstrap/Load: Fix missing object argument for singular capability checks and support capability tests overlooked in [44524].
See #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: fc37b17
svn: r44524
255 of 1494
Author
Felix Arntz <[email protected]> 2019-01-09 20:04:55 +0000
Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard.
This changeset introduces a `WP_Shutdown_Handler` class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.

Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.

The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.

Websites that have custom requirements in that regard can implement their own shutdown handler by adding a `shutdown-handler.php` drop-in that returns the handler instance to use, which must be based on a class that inherits `WP_Shutdown_Handler`. That handler will then be used in place of the default one.

Websites that would like to modify specifically the error template displayed in the frontend can add a `php-error.php` drop-in that works similarly to the existing `db-error.php` drop-in.

Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 493b90c
svn: r44519
256 of 1494
Author
Boone Gorges <[email protected]> 2019-01-09 15:10:17 +0000
Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg.
Introduced in [42211].

Fixes #36514.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f27fc64
svn: r44518
257 of 1494
Author
Jonathan Desrosiers <[email protected]> 2019-01-09 14:54:11 +0000
Docs: Update `since` annotations for adding `LIKE` comparisons with meta keys.
Previously introduced in [42768].

Fixes #42409.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 6bb50ec
svn: r44517
258 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 13:44:30 +0000
Build/Test Tools: Update `.gitignore` to exclude `twentynineteen` and `twentysixteen`.
Brings the list of bundled themes in `.gitignore` up to date.

Fixes #45474.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 1264df8
svn: r44516
259 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 12:36:43 +0000
Build/Test Tools: Fix coding standards issues after [44515] and [44514].
See #44494, #43743.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: aa3be48
svn: r44515
260 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 12:04:32 +0000
Taxonomy: Display term list table in full width if there is no edit form.
Makes sure there is no empty space when a user can manage terms but lacks the capability to edit terms.

Props mathieuhays, marcwieland95.
Fixes #43743.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a8cb5d2
svn: r44514
261 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 11:45:02 +0000
I18N: Add option to hide en_US locale in `wp_dropdown_languages()`.
Props danieltj for initial patch.
Fixes #44494.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e4e9010
svn: r44513
262 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 11:25:19 +0000
Upgrade/Install: Prevent possible JavaScript error when updating translations.
Props Presskopp.
Fixes #39189.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 916695b
svn: r44512
263 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 11:13:03 +0000
Tests: Revert [44509].
This commit causes Travis to fail.

See #45863.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: a5594e7
svn: r44511
264 of 1494
Author
Pascal Birchler <[email protected]> 2019-01-09 10:53:14 +0000
Embeds: Fix typo introduced in [44484].
Props JustinSainton.
Fixes #45036.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ec7687b
svn: r44510
265 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 10:30:49 +0000
Tests: Improve REST API tests for categories and tags.
Props birgire, SergeyBiryukov.
See #39122.
Fixes #45077.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 0137c23
svn: r44509
266 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 10:13:13 +0000
Build/Tests: Default to running unit tests from `src`.
This is the actual commit, unlike [44508], which was not.

Props atimmer.
See #44492.
Fixes #45863.


git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 4198e71
svn: r44508
267 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 10:09:02 +0000
Build/Tests: Default to running unit tests from `src`.
This commit also defaults WP-CLI commands to running against `src`, too.


Props atimmer, pento.
See #44492.
Fixes #45863.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ed1b4dc
svn: r44507
268 of 1494
Author
Dominik Schilling (ocean90) <[email protected]> 2019-01-09 10:01:32 +0000
Build/Tools: Fix typo in `phpcs.xml.dist`.
See #44366.

git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: ba495ec
svn: r44506
269 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 09:50:19 +0000
Filesystem: Improve `wp_is_stream()` performance.
Instead of turning the return value of `stream_get_wrappers()` into a regex to match the scheme, we can instead extract the scheme and search the return value of `stream_get_wrappers()`.

Props schlessera, swissspidy.
Fixes #45553.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: f3b7b7f
svn: r44505
270 of 1494
Author
Peter Wilson <[email protected]> 2019-01-09 08:36:07 +0000
Cron: Fix undefined variable notice.
Restore `$gmt_time` variable removed in error from [44483].

Props afragen.
Fixes #45870.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: e5b5db9
svn: r44504
271 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 06:53:15 +0000
Block Editor: Obey the `AUTOSAVE_INTERVAL` constant.
Props youknowriad.
Fixes #45262.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet
git: 2a6e44a
svn: r44503
272 of 1494
Author
Gary Pendergast <[email protected]> 2019-01-09 06:51:38 +0000
Docs: Correct the documentation for `wp_list_authors()`.
The `exclude_admin` argument defaults to `true`, not `false`.

Props haruharuharuby.
Fixes #45120.



git-svn-id: https://develop.svn.wordpress.org/[email protected] 602fd350-edb4-49c9-b593-d223f7449a82
No action taken yet